Skip to content

refactor: remove duplicate package import#1425

Open
liuyueyangxmu wants to merge 1 commit intodymensionxyz:mainfrom
liuyueyangxmu:main
Open

refactor: remove duplicate package import#1425
liuyueyangxmu wants to merge 1 commit intodymensionxyz:mainfrom
liuyueyangxmu:main

Conversation

@liuyueyangxmu
Copy link

@liuyueyangxmu liuyueyangxmu commented Dec 2, 2025 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

github.com/dymensionxyz/roller/utils/eibc was imported twice.
I remove the duplicate import to make the code cleaner and more readable.

For Author:

  • Targeted PR against correct branch
  • Included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case PR targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@liuyueyangxmu liuyueyangxmu requested a review from a team as a code owner December 2, 2025 14:36
@liuyueyangxmu
Copy link
Author

liuyueyangxmu commented Dec 6, 2025

@mtsitrin Thank you for your approval.

@liuyueyangxmu
Copy link
Author

liuyueyangxmu commented Dec 6, 2025

It seems that the CI failure is unrelated to this change

env:
    GOPRIVATE: github.com/dymensionxyz/*
    GH_ACCESS_TOKEN: 
/home/runner/_work/_temp/014aaab4-56c8-4a3d-9d4e-a8ddd3bec9ad.sh: line 1: make: command not found

artemijspavlovs
artemijspavlovs requested changes Dec 15, 2025
View reviewed changes
Copy link
Collaborator

@artemijspavlovs artemijspavlovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use an alias - eibcutils

@liuyueyangxmu
chore: remove duplicate package import
1eac6d0 
Signed-off-by: liuyueyangxmu <liuyueyangxmu@outlook.com>
@liuyueyangxmu
Copy link
Author

liuyueyangxmu commented Dec 16, 2025

use an alias - eibcutils

@artemijspavlovs Thank you for your review.

Modified. Please review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artemijspavlovs artemijspavlovs artemijspavlovs requested changes

@mtsitrin mtsitrin mtsitrin approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuyueyangxmu @artemijspavlovs @mtsitrin